Florian Albrechtskirchinger

Results 136 comments of Florian Albrechtskirchinger

> Please try also in Release mode. Niels, he did. It's in the title. :-) That's why I had to ask for clarification the last time.

> @falbrechtskirchinger I've tried the latest release version [b5364fa](https://github.com/nlohmann/json/commit/b5364faf9d732052506cefc933d3f4e4f04513a5) of release/3.10.5 branch. But the error still exist. And the failed error are same. > > As you said 'The error...

But that would still be an issue outside the library, right? AFAICT, `std::string::replace` should deal with resizing the string. I did grep through libstdc++ trunk, and `std::vector` is still the...

Digging a little bit deeper, the code triggers a recursion in `__partially_ordered_with` via `std::operator `. For `std::optional`, that recursion is broken via the constraint `__is_optional_v`. Adding a specilization to `std`...

This might be related to #3425. I'll check if any of the provided examples trigger the assertions I've added to at least catch some problematic conversions between `basic_json` types. And...

Ok. The people who commented on this matter seem to be experiencing related but different issues. @sirzooro What you reported is working as designed. I agree, though, that the conversion...

The workaround I mentioned before is still the only way to solve this I could think of so far. Any other solutions I considered are breaking changes and would have...

The patch to the `CompatibleType` constructor from my previous post breaks a lot of things and PR #3518 only covers the `basic_json` converting constructor. Other than adding `JSON_EXPLICIT` to the...

> * Remove default value initialization, which does not seem to be used, such that union is valid > * Made `iter_impl` copy construction default, such that it is trivially...

A few issues at first glance: * The internal SAX classes should continue to avoid polymorphic inheritance. * Existing classes should still work without having to add the new member...