ぐるぐる

Results 14 comments of ぐるぐる

Thank you for approving. Now I merged latest main branch.

I just noticed this PR has some conflict, and I fixed it. As you said, I do not have permissions to merge this PR. Therefore, I would appreciate if someone...

Sorry for late reply. Now I can resolve conflicts, however it requires many approval to merge this PR. I would like to close this PR, and split this PR by...

Thank you @LegitYew0108 ! I confirmed yaml-cpp errors on standalone mode, and fixed it.

Here is my version of ros2-for-unity: https://github.com/RobotecAI/ros2-for-unity/pull/125 In addition to these PR, you may need to use this patch for build errors: https://github.com/RobotecAI/ros2cs/pull/69

In our runner, we use encode to convert a Python dict into XML. Therefore, there might be some unexpected cases involved. I've created a minimal reproducible example below. https://gist.github.com/f0reachARR/11e749e566a373937a38ec531efeb83a

Thank you for response and adding extension about string literal! I tested non-string numeric value and it works well. We are trying to refine our implementation to handle integer value...

Thank you for extending compatibility! I tried with our cases and confirmed the problem of `` is fixed. However, in case of boolean string literal like "False", I encountered another...

Thank you for reply! As you pointed out, `True` and `False` are not valid as `xs:boolean` values. I will fix it on our source code.

Could you review this PR? @kyoichi-sugahara @TakaHoribe @kminoda (Code owners)