Philip Wenig

Results 28 comments of Philip Wenig

Keep the identifier as they are, otherwise the `ILibraryService` to retrieve the reference spectrum would fail again: ``` private static final String IDENTIFIER = "Scan Maxima Detector UI"; // $NON-NLS-N$...

With high resolution mass spectrometry data, a range (±) is probably needed: `427.240±0.02, 279.092±0.02 (x5.3), 428.240±0.03`

In HPLC-DAD a range (±) is also needed: `210±2`

In high-res mass spectrometry, the term `ppm` should be also supported: https://warwick.ac.uk/fac/sci/chemistry/research/barrow/barrowgroup/calculators/mass_errors `400.01627±10ppm` => `±0.004000163` 400.01627 * 10 / 1000000 = 0.004000163

I would recommend to review this issue and try to keep the "Trace Support" as simple as possible.

Internally, the term "trace" is used as a generic placeholder for m/z values or wavelengths. We should keep it internally as trace. But you're right, the front end labels might...

Yep, correct :-). The layer on top, especially used in the template processor, uses "trace" as a synonym. A ticket, which is also in progress, is worth to be mentioned...

In my opinion, that's a fine approach for NMR and FTIR, NIR, ... . In the aforementioned cases, we have one scan, which contains the needed spectral information. In case...

The concept of a edit history, change logbook exists already: IEditHistory editHistory = chromatogram.getEditHistory(); Probably, additional information can be placed in the history. Am 16.10.19 um 16:29 schrieb Kerner: >...

I would also appreciate if the artifacts are moved to Maven Central.