chemclipse icon indicating copy to clipboard operation
chemclipse copied to clipboard

DAD wavelengths are incorrectly called traces in the overlay

Open Mailaender opened this issue 4 years ago • 4 comments

This is somehow in between wrong and a polish problem. DAD wavelengths aren't traces which is confusing wording and the defaults like column bleeding mass traces from GC don't make any sense in LC-DAD scenarios. Someone who uses MS and DAD detectors at the same time might want to save user-defined settings for both without switching all the time in the chromatogram overlay.

Mailaender avatar Aug 04 '21 14:08 Mailaender

Internally, the term "trace" is used as a generic placeholder for m/z values or wavelengths. We should keep it internally as trace. But you're right, the front end labels might make a differentiation.

eselmeister avatar Aug 04 '21 14:08 eselmeister

Even internally it is called wavelength as far as I see: https://github.com/eclipse/chemclipse/blob/9921848d8970bcb996d71ce9a416d06437026c49/chemclipse/plugins/org.eclipse.chemclipse.wsd.model/src/org/eclipse/chemclipse/wsd/model/core/support/IMarkedWavelengths.java#L19

Mailaender avatar Aug 04 '21 18:08 Mailaender

Yep, correct :-).

The layer on top, especially used in the template processor, uses "trace" as a synonym. A ticket, which is also in progress, is worth to be mentioned here: https://github.com/eclipse/chemclipse/issues/427

eselmeister avatar Aug 04 '21 18:08 eselmeister

Trace wavelength is a term in acoustics https://asastandards.org/Terms/trace-wavelength/ but not in analytical chemistry.

Mailaender avatar Aug 09 '21 08:08 Mailaender