Adam Curtis

> > I think it's now complaining that the type is no longer an integer and is instead Dictionary > > That seems like you could just update the test....

rebased onto main

@peter-toth > the issue of String identifiers are explained in my PR. I have a solution for the issue, but https://github.com/apache/datafusion/pull/10396 is already huge and the implementation will be a...

I don't have my environment set up properly to test it yet, but I have a tentative script written in livescript. ``` livescript require! dump2redis = module.exports = (filePath, client)...

The test failure here is caused by a bug in the `log` UDF simplifier. I've filled an issue https://github.com/apache/datafusion/issues/10359 and submitted a PR https://github.com/apache/datafusion/pull/10360 to fix it.

I future proofed the naming a bit by renaming "iterations" to "cycles", because I can improve the algorithm a bit further to short-circuit mid-cycle and so we might later want...

I've made a new algorithm for this that should in theory reduce the amount of work needed to be done by short-circuiting earlier once there is a consecutive sequence of...

Benchmark results https://github.com/apache/datafusion/pull/10386#issuecomment-2095082079

PR for this is ready for review https://github.com/apache/datafusion/pull/10358. Maybe as a follow up feature we should expose the maximum number of iterations as a configuration parameter?

Are there any potential issues with simply using the existing `Hash` implementation of `Expr` to create `HashSet`s? Serveral other optimization passes use string names as keys for expressions in data...