Adam Curtis
Adam Curtis
Hey I am interested in helping with this. Maybe @peter-toth and I can divide our efforts here? Let me know what you've worked on so far, and I can figure...
Actually it looks like `ExprSet` needs to be completely redesigned because it relies on cloning the `Expr`s. I've started [a branch](https://github.com/erratic-pattern/arrow-datafusion/commits/adam/no-copy-common-subexpr-elim/datafusion/optimizer/src/common_subexpr_eliminate.rs) for my work. Here is a [basic commit](https://github.com/erratic-pattern/arrow-datafusion/blob/d00261bdd892a36d98a1491f7fe3b6405daf39d0/datafusion/optimizer/src/common_subexpr_eliminate.rs#L405-L445) that...
>I don't have time to work on this soon, but would you like to take it on? Yep I'll play around with it and see if I can get it...
@froth I was able to reproduce this issue with the provided example crate just a month ago, but now it's working... exact same miette version. So I am wondering if...
@zkat I've been working on some basic backtrace stuff with miette as a library user, but I could try to adapt it into a proper feature at some point. backtrace...
The use case with backtraces that I built on top of miette is to actually show source code from failing unit tests. To do this I use `track_caller` to find...
Made some improvements on my previous version of panic reporting by using actual Diagnostics sources instead of ad-hoc cause chains. So now there's a root `Panic` report and then a...
This proposal was approved on the Arrow dev mailing list. [See thread here](https://lists.apache.org/thread/zoyv6d4fzco4h48b66wqwmfc6w31757x)
I mentioned [here](https://github.com/apache/arrow-rs/pull/5433#discussion_r1511392897) in the Rust PR that I would like to expand the Go tests to cover both the stateful and stateless cases, but I didn't spend much time...
@zeroshade A review would be much appreciated. The PR is in draft state until the spec is voted on, but the code change is more or less "Done"