Adam Curtis
Adam Curtis
I must have forgotten to commit the protobuf generated code in this branch. I've run `go generate` locally on [the format PR](https://github.com/apache/arrow/pull/40243) and committed the changes to this PR.
@zeroshade Not sure how to interpret this CI failure. It seems to involve a Java client integration test. Can you take a look? https://github.com/apache/arrow/actions/runs/8352550401/job/22934920078?pr=40311
The proposal for this specification change was approved on the Arrow dev mailing list. [See thread here](https://lists.apache.org/thread/zoyv6d4fzco4h48b66wqwmfc6w31757x) I've moved this PR out of draft status.
> Shouldn't there be updates to client.go here? Looks like I forgot to add this. I'll take a look.
I see that [`writeBindParameters`](https://github.com/erratic-pattern/arrow/blob/70e7ae5ed336c3670c4ea83cdb039cfafb80c833/go/arrow/flight/flightsql/client.go#L1214-L1235) is where the client needs to be updated, but it's not clear to me how I should change it to read a single message from the...
I've updated this PR with the client-side implementation, which waits for a `PutResult` and captures the stored prepared statement handle for subsequent requests. There are some integration test failures related...
Okay, tests have been updated and are passing locally. The new test failure in CI is a bit of a mystery. https://github.com/apache/arrow/actions/runs/8676995733/job/23792073344?pr=40311#step:6:68 ``` --- FAIL: TestSqliteBackend (19.24s) --- FAIL: TestSqliteBackend/TestRowsPrematureCloseDuringNextLoop...
Done. I resolved the conflict by re-running `go generate` again @matthewmturner @zeroshade Let me know if that worked.
I do think the concerns about "spec bloat" are valid. If there aren't enough of these sort of "opt-in" behaviors then it may not be worth complicating the handshake. Echoing...
I have a PR that fixes this. https://github.com/apache/datafusion/pull/10221 Here is the explain after making the change: ``` > explain SELECT * from test where column1 = 1; +---------------+-----------------------------------------------------+ | plan_type...