eric846

Casting an integer to an enum outside the defined range doesn't throw but produces undefined behavior. And C++ has no maintainable way to check for the largest value in this...

Consider compound StepControllers

1

> oschaaf: I wonder if this might get simpler if it would be split into two step controllers, one for the exponential search, and one for the binary search. The...

Consider moving the responsibility out of plugin_loader, since a factory should be able to do the validation on its own. Still provide a way to force plugin implementers to consider...

Consider noexcept or other mechanism to guarantee that absl::Status captures all cases

1

Possible solutions: - plain comments advising not to throw - a new macro that clang-tidy looks for - noexcept

- Having their own unit tests - For use in multiple unit tests

I originally created RequestsPerSecondInputVariableSetterConfig to avoid adding extra code to support the config proto being optional. But it turns out that each plugin will be created by copy-paste, so it...