eric846

This will allow reusing all of AdaptiveLoadClientMain in a customer-specific minimal wrapper executable that needs to create a custom gRPC channel with a transport other than insecure and TLS.

process_test unit test behaves differently on CI and local machine

1

https://github.com/envoyproxy/nighthawk/blob/e6f9af70d446ee018f1d72f8e46b8c1a22c186f4/test/process_test.cc#L279 With `TimestampToNanoseconds`, passes on CI but fails on my machine with error: ``` test/process_test.cc:278: Failure Expected equality of these values: Envoy::ProtobufUtil::TimeUtil::TimestampToNanoseconds( output.results()[0].execution_start()) Which is: 1610660382038451000 options_->scheduled_start().value().time_since_epoch().count() Which is: 1610660382038451...

Adaptive Load Controller

2

Create a tool that repeatedly calls a Nighthawk Service with brief benchmarks at different RPS values and adjusts the RPS based on latency, logging all results. Create a C++ library...

There is some duplicate work (loading plugins during validation and again during the actual run) that made more sense before `AdaptiveLoadControllerImpl` was made into a class.

Consider generalizing the adaptive load "testing stage"

1

Today we have to deal with the adjusting stage and testing stage having separate durations, and the fact that the traffic template is a full `CommandLineOptions` with a duration field...

Reconsider failure predicate defaults and/or consider shortcuts for setting them

1

Should Nighthawk exit by default after a single 5xx? We were suprised to discover an benchmark had been exiting after less than the specified time because of errors, and it...

For example `MakeFakeInputVariableSetterConfig()` doesn't return a `FakeInputVariableSetterConfig`, it returns a `TypedExtensionConfig` with a `FakeInputVariableSetterConfig` packed into an `Any` in the `typed_config` field. It should be renamed `MakeFakeInputVariableSetterTypedExtensionConfig()`.

Consider consolidating IsConverged and IsDoomed in Adaptive Load StepController

1

Both are const methods that can change value from the same events. - We might think of other predicates. - It could also allow us to encode constraints like doomed...

Currently it uses a boolean return code plus optionally written output parameter, increasing the temptation to use "" to convey information.