eric846

We got interrupted before creating the CLI wrapper executable, but we still plan to do that.

Added some advice about `localhost`, `::1`, `127.0.0.1`, and `--address-family v4` / `v6` to the troubleshooting tips in the "error 13" message. This should be enough to unblock most situations.

All sounds good. (I'm not planning to work on it myself.)

I just realized a way to reduce the effort. We can just let the user specify a list of HTTP codes they want to break out as separate counters. Then...

We may be able to delete many tests that contain `getAndCheckFactoryByName` if we have a centralized test.

As of #641, some tests had strict equality counts, but for example `test_http_h2` had some relaxed checks. We probably want all similar tests to either be uniformly strict or lax.

Instead of: ``` FakeMetricsPluginConfig metrics_plugin_config; FakeMetricsPluginConfig::FakeMetric* fake_metric = metrics_plugin_config.mutable_fake_metrics()->Add(); fake_metric->set_name(kMetricName); fake_metric->mutable_error_status()->set_code( static_cast(absl::StatusCode::kPermissionDenied)); fake_metric->mutable_error_status()->set_message("expected status message"); ``` we would like to have: ``` FakeMetricsPluginConfig metrics_plugin_config = MAGIC(R"proto( fake_metrics { error_status {...

Instead of: ``` ASSERT_TRUE(output_or.ok()); EXPECT_EQ(output_or.value().myfield(), "field value"); ASSERT_FALSE(output_or.ok()); EXPECT_EQ(output_or.status().code(), absl::StatusCode::kDataLoss); EXPECT_EQ(output_or.status().message(), "artificial spec error"); ``` we would like to have: ``` EXPECT_THAT(output_or, IsOkAndHolds(R"proto( myfield: "field value" )proto")); EXPECT_THAT(output_or, StatusIs(absl::StatusCode::kDataLoss, "artificial...

(If it makes sense)

Nighthawk doesn't currently support `http_proxy`/`https_proxy` environment variables or connecting to a proxy using credentials. (I changed this issue from a `bug` to a `question`. Feel free to change it to...