Enrico Olivelli

Results 446 comments of Enrico Olivelli

@jbonofre I have a followup patch, regarding Equals and Not expressions. I will do have numbers within the end of the week.

@jbonofre I have a couple of additional enhancements. I have some numbers on our applications (with this PR + the follow up patches, all stacked), we are saving some good...

@lhotari since 2.8 you can configure the bookkeeper client inside the broker just by adding bookkeeper_xxx in broker.conf check for instance the case of "bookkeeper_opportunisticStriping"

The change overall looks good, very good ! but unfortunately there are still failing tests, we need all tests to pass before committing the patch

there is a checkstyle violation: > [INFO] There is 1 error reported by Checkstyle 8.37 with ../buildtools/src/main/resources/pulsar/checkstyle.xml ruleset. > Error: src/main/java/org/apache/pulsar/broker/stats/prometheus/NamespaceStatsAggregator.java:[372] (regexp) RegexpSingleline: Trailing whitespace > [INFO] ------------------------------------------------------------------------

my IDE reformatted part of the code, I will revert

@PhantomThief do you have cycles to follow up on this patch ?