activemq icon indicating copy to clipboard operation
activemq copied to clipboard

AMQ-8613 Improve performance of selectors with a big sequence of OR and AND logical expressions

Open eolivelli opened this issue 3 years ago • 5 comments

eolivelli avatar May 27 '22 07:05 eolivelli

@eolivelli can you please squash all commits in one ? Thanks !

jbonofre avatar May 27 '22 08:05 jbonofre

@jbonofre I have a followup patch, regarding Equals and Not expressions.

I will do have numbers within the end of the week.

eolivelli avatar May 31 '22 11:05 eolivelli

@eolivelli thanks, no worries. I plan to do a first review pass tonight anyway.

jbonofre avatar May 31 '22 12:05 jbonofre

@jbonofre I have a couple of additional enhancements. I have some numbers on our applications (with this PR + the follow up patches, all stacked), we are saving some good amount of CPU cycles and we decided to commit these changes in our repo. @dave2wave has some numbers, but I am not sure they are meaningful here.

eolivelli avatar Jun 14 '22 09:06 eolivelli

Great ! I will do a new pass. Thanks !

jbonofre avatar Jun 14 '22 12:06 jbonofre

@jbonofre thank you for merging this patch. I will follow up with a second part.

eolivelli avatar Aug 17 '22 06:08 eolivelli