ellinge comments

Results 12 comments of


                                            ellinge

feat: Prefix instance id when custom node id is passed

@mrchief the change on the resolved conversation should be reverted? Or was that another change that was needed?

Hotreload not working with .cshtml files

> I had a similar issue and my .cshtml worked once I did the following: > > ``` > > > > > ``` > > I needed to do...

Set permanent as default redirect configuration

No it’s set as selected in template: https://github.com/Geta/geta-notfoundhandler/blob/2ed3c5f746d5497fd9f0a6432aa453935e2b8a9e/src/Geta.NotFoundHandler.Admin/Areas/GetaNotFoundHandlerAdmin/Pages/Index.cshtml#L48

Feature request: Sortable headers in the Redirects tab

I’m not part of Geta so it’s up to them

Ignore suggestions based on previously ignored

@marisks shouln't logEvents.Count be used instead of bufferSize in check of threshold as well? Here I mean: https://github.com/Geta/geta-notfoundhandler/blob/3d68a8d7ac530a91fb9b66e05a55429ec9dd3ec8/src/Geta.NotFoundHandler/Core/Suggestions/RequestLogger.cs#L68

Ignore suggestions based on previously ignored

How soon? It would be nice to avoid getting a lot of suggestions already ignored.

Keeps search state on post, allow order by column

The problem with current implemenation, in addition to the bad user experience, is that you fetch all posts instead of pagination on database side. A removed third party dependency for...

Keeps search state on post, allow order by column

If I tried to work around these issues could you have another look or is that just wasted time?

Keeps search state on post, allow order by column

Now public interfaces are restored and GET:s and POST:s are separated.

Show modal in same position (height) as trigger of modal

Not sure what to to with the build failing, tests seems to pass but I think your sonar-configuration is off. Seems to have to do with the build being processed...