geta-notfoundhandler icon indicating copy to clipboard operation
geta-notfoundhandler copied to clipboard
verified publisher icon Geta

Ignore suggestions based on previously ignored

Open ellinge opened this issue 2 years ago • 3 comments

Fixes #37

Now suggestions are not added if a matching ignore is found.

Also rewrote the buffering of 404 to allow logging if threshold has passed as well. Meaning the buffer can be less than buffersize before being processed. Seems logical to me but perhaps there's a reason for waiting to fill the buffersize always.

ellinge avatar Feb 10 '23 13:02 ellinge

@marisks shouln't logEvents.Count be used instead of bufferSize in check of threshold as well?

Here I mean: https://github.com/Geta/geta-notfoundhandler/blob/3d68a8d7ac530a91fb9b66e05a55429ec9dd3ec8/src/Geta.NotFoundHandler/Core/Suggestions/RequestLogger.cs#L68

ellinge avatar Feb 10 '23 13:02 ellinge

We are working on rewriting the whole logging logic for Suggestions. This PR will be out of date soon.

marisks avatar Feb 17 '23 08:02 marisks

How soon? It would be nice to avoid getting a lot of suggestions already ignored.

ellinge avatar Feb 17 '23 08:02 ellinge

Closing this issue, due to the fix was provided here: https://github.com/Geta/geta-notfoundhandler/pull/134

jevgenijsp avatar Nov 05 '24 10:11 jevgenijsp