Elias W. BA

Results 26 comments of Elias W. BA

The only place I can see an error happening that the worker wouldn't be aware of is when we maybe refresh the credential before sending the job to the worker....

@elias-ba when reviewing, please focus on (1) sensitive data we may send to the worker (2) does this pr cover changes brought in later (like refresh flow).

Closing in favor of #2289 2289

Closing now as the intent of this code was implemented in #2289 in July. It was reopened accidentally.

### Review / change requests progress - [x] Remove default validation on the text fields when a modal loads - the data validation should only show when a user tries...

> ![image](https://private-user-images.githubusercontent.com/144796/329599105-57bb8824-6985-4ccc-8237-e15ba16c1dec.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTUzNjQ1OTMsIm5iZiI6MTcxNTM2NDI5MywicGF0aCI6Ii8xNDQ3OTYvMzI5NTk5MTA1LTU3YmI4ODI0LTY5ODUtNGNjYy04MjM3LWUxNWJhMTZjMWRlYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNTEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDUxMFQxODA0NTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00M2JlZDY5MWZlMjBlZGM3MjliOGQ0YzA0NWYxNGM1MDFiZjllODBmZTlhNjlkYzZhMmQ2NDQxNTQ4NWYyMTM4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.lGuCy66FacTuAF41d0_8jpMsQV5-nLRJM1VCaherXVE) > > @christad92 @elias-ba, some feedback so far 👆 > > Also if I add only one scope (as in type without entering a `,`) and click save...

@taylordowns2000 this looks like a valid way to implement this. I am not sure I can't validate it's relevancy but it seems to me as a better way of dynamically...

The fix for this issue is partly implemented here: #2149. But it's blocked by #1825.

@christad92 I would say partly fixed it. But we will probably come back to it for pure engineering review / optimisation.

The solution to this problem seems much more expensive than the current budget. I spoke with @stuartc and @christad92, and we all think it's better if I solve the most...