Persist run options & set at creation (not claim)
Requesting guidance before going further. Does this feel like the right way to address the run options issue?
Required context (pre-reading) to review:
- https://github.com/OpenFn/lightning/issues/2079
- https://github.com/OpenFn/lightning/issues/2082
Note that if we like this idea, next we still need to:
- remove the "get options" bit that happens during claim
- ensure that these options are delivered properly via the channel to the worker
- check to see which options are set by the project admin (e.g., enable dataclip storage) and which options are set by the instance administrator (e.g., max run duration)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.61%. Comparing base (
4af6f2a) to head (b3e7d2c).
:exclamation: Current head b3e7d2c differs from pull request most recent head 3dd2a03
Please upload reports for the commit 3dd2a03 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## main #2085 +/- ##
=======================================
Coverage 89.60% 89.61%
=======================================
Files 269 270 +1
Lines 8949 8955 +6
=======================================
+ Hits 8019 8025 +6
Misses 930 930
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@stuartc , please take a look here! context in the PR itself
@taylordowns2000 this looks like a valid way to implement this. I am not sure I can't validate it's relevancy but it seems to me as a better way of dynamically calculating the run options. Maybe wait for @stuartc to confirm that point.
@taylordowns2000 this implementation looks good to me (assuming that tests and other bits will come later)
Oh and yes, @taylordowns2000 - tests please!
nice. think we're good now @stuartc