eignnx

Add wrapping fn for `Fn(&str) -> IResult<&str, T>` parsers

2

As far as I can tell, some nom parsers (like `re_find!`) aren't generic enough, and must accept `&str` input. This means you can't pass them a `LocatedSpan`. It would be...

Firefox: No auto-focus to search bar

2

I'm using Firefox Quantum 57.0.1 and when I open a new tab, the cursor doesn't automatically jump into the search box. Not a huge deal, but it does makes searching...

Docs hard to read on mobile

1

The documentation is hard to read on mobile devices. The pages aren't responsive to different screen widths. I wonder if there are CSS wizards in the SWI community who would...

Bounds checking

6

Comments in the code suggest that `_dynarray_{get,set}` do bounds checking. In fact they do not, I must have forgot to add that. Bounds checking should be added.

If `malloc` (or `realloc`) cannot allocate the requested memory, it will return `NULL`. Currently this library does not check for this condition. How should this be handled? Is it worth...

Use realloc

1

During reallocation this implementation calls malloc and free to create a new buffer twice the size and to deallocate the old buffer. The function `realloc` can be more efficient because...

https://github.com/eignnx/dynarray/blob/master/dynarray.h#L14-L19 This anonymous enum uses up some semi-common identifiers like `LENGTH` which may appear in application code that uses this library. The enum members should be renamed to something specific...

There seems to be no way for SWI Prolog to read exactly one byte from `user_input` on Windows. This is because `user_input`'s encoding is locked as `wchar_t` which on Windows...

JSON RPC Batched Request Support?

1

The JSON RPC spec talks about [batched requests](https://www.jsonrpc.org/specification#batch) where a JSON array of request objects is sent. Is this something the server needs to support?