Enrique Fernandez Perdomo

Thanks for your contribution, but I'd like to have https://github.com/clearpathrobotics/ros_controllers/pull/10 merged upstream. Do you think it'll also fix your needs? I think I could have all clearpathrobotics merged upstream in...

I'm working on: 1. merging all pending PRs on clearpathrobotics fork 2. adding a unit test suite for the speed_limiter in order to diagnose and fix a problem with a...

I have something like this in https://github.com/clearpathrobotics/ros_controllers/commit/22b106a31be90cddd0b34ee5c9aa55ebc06cedce and a bunch of critical issues addressed in later commits. That's the only reason I'd refrain for merging this... it'd be difficult to...

@wxmerkt I'm quite busy, but @tonybaltovski will help me to get the bits you need upstream. I'd try to bring other features soon as well, as the covariance, etc. My...

@bmagyar @wxmerkt Fair enough, especially because each feature will have to be validated and tested. I don't think the fork is used at all (or has been tested) in research...

@wxmerkt 1. I think you mean the `left_wheel_radius_multiplier` and `right_wheel_radius_multiplier`. Yes, they were added, and I think in your test they were in. If you where using multipliers other than...

FYI @wxmerkt @artivis

This is between a "bug" and an "enhancement" b/c the twist should have a small (but still have) `y` component. Please ignore the fact I used SE(2) from **sophus** here,...

I could use `Eigen` or `tf` transforms, but the could will change in future PRs anyway: https://github.com/clearpathrobotics/ros_controllers/blob/indigo-devel/diff_drive_controller/src/odometry.cpp#L176 I can still do it if you insist, but it'd slow things down....

> I see that there's actually not much code affected...would you mind using Eigen of tf instead please? Will do that