eerus

Results 9 comments of eerus

@v-sabiraj , @manishkumar1991 , @rahul0216 , we understand that you're probably having a busy day. Is there anything we can do to unblock the review?

> > @v-sabiraj , @manishkumar1991 , @rahul0216 , we understand that you're probably having a busy day. Is there anything we can do to unblock the review? > > @yinghuang123...

@v-sabiraj and @petebryan we made the changes that you requested. Most of the files, in which you requested the changes, are deleted now. What else would you like us to...

@manishkumar1991 , I hope that we satisfied the requirements about metadata in playbooks and the keyvault. Is there anything else we need to do? If possible, would you be able...

@manishkumar1991 , we added the keyvault name to to the azuredeploy.json, so now there's no need to ask for it during connection authorization. Now our Azure deployment uses he same...

@v-sabiraj , we reviewed [data connector](https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/CiscoUmbrella/Data%20Connectors?rgh-link-date=2023-01-02T09%3A34%3A42Z) but we didn't understand what exactly we had to do because there are differences. 1. We have 2 function apps (2 projects combined in...

> > @manishkumar1991 , we added the keyvault name to to the azuredeploy.json, so now there's no need to ask for it during connection authorization. Now our Azure deployment uses...

@petebryan , @manishkumar1991 and @v-sabiraj, we appreciate all your comments. I'm happy to confirm that we committed a new code and responded to all your suggestions. As along as we...

> @manishkumar1991 , we hear and value your comment but you're suggesting more _manual_ steps while we'd like to make less. Please correct me if I'm wrong. Here's what you...