Eldad Bercovici

Possible optimization to useSyncExternalStore's withSelector

11

https://github.com/facebook/react/blob/dd2d6522754f52c70d02c51db25eb7cbd5d1c8eb/packages/use-sync-external-store/src/useSyncExternalStoreWithSelector.js#L70-L91 Hey, isn't line 89 in block above supposed to be right before line 78? I mean, if `prevSnapshot` and `nextSnapshot` are not equal, but `prevSelection` and `nextSelection` _are_ equal,...

Hi! 👋 Firstly, thanks for your work on this project! 🙂 Today I used [patch-package](https://github.com/ds300/patch-package) to patch `[email protected]` for the project I'm working on. This makes useAsync infer the type...

Entity adapter re-sorts all ids (O(n*log(n)), instead of just inserting the new id into the "right" place (O(log(n)))

6

Hey 👋 Why is it that when adding (or removing/updating/etc...) items inside an entity-adapter's state, entity-adapter will first [push into the array](https://github.com/reduxjs/redux-toolkit/blob/master/packages/toolkit/src/entities/sorted_state_adapter.ts#L133-L140), then run `.sort(sortFn)` on the entire array? Wouldn't...

This PR has 3 commits, one that adds `props.rowHitAreaHeight`, another one that adds `props.ignoreDropsOutside` and a version bump commit. `rowHitAreaHeight` - gives the user control over the height or a...