Eldad Bercovici comments

Results 6 comments of


                                            Eldad Bercovici

Example from README is not working

I was able to reproduce on a simple CRA project: ``` npx create-react-app my-project --template typescript yarn add react-cmdk yarn start ``` Then add the code from the readme into...

Example from README is not working

Also, I'm adding these tags so people will find this issue easily: ``` Uncaught TypeError: Cannot read properties of undefined (reading 'Child') ```

Entity adapter re-sorts all ids (O(n*log(n)), instead of just inserting the new id into the "right" place (O(log(n)))

Copying is by orders of magnitude cheaper than whatever sortFn does, which is up to the user anyhow.

Entity adapter re-sorts all ids (O(n*log(n)), instead of just inserting the new id into the "right" place (O(log(n)))

And I'm not sure where you got the impression that resorting an almost sorted array issues less than n*log(n) calls. Try logging how many times sortFn is called when triggered...

Entity adapter re-sorts all ids (O(n*log(n)), instead of just inserting the new id into the "right" place (O(log(n)))

Oh wow, you're right! When dealing with 1000s of items + using immer (RTK) this does get a lot slower. Not sure if because of the equality function reading "through"...

cant resolve os

Check this out: https://stackoverflow.com/questions/70342852/cant-resolve-os-webpack-5