Dilip
Dilip
> @dshekhar95 @matthewmcneely - I was trying looking at the cherry-pick PR #8007 summary - and I have a few thoughts here: > > * from what is explained there,...
> only 1 test in loader so maybe makes sense?
> There doesn't seem to be much test coverage for this. I found a thread that discusses issues with testing ACLs when they were first added: https://discuss.dgraph.io/t/acl-testing-findings/4920/3 > > @dshekhar95...
Cherry-pick is causing a failure on the following test: TestAuthQueryRewriting/Query_Rewriting_HS256/Query_interface_should_return_all_the_nodes_of_a_type_if_rbac_rules_of_type_are_true (0.00s) --- PASS: TestAuthQueryRewriting/Query_Rewriting_HS256/Fragments_in_auth_queries_with_user_defined_cascade (0.00s) --- FAIL: TestAuthQueryRewriting/Query_Rewriting_HS256/Query_auth_rules_with_filter_on_field_with_ID_type (0.00s)
https://github.com/dgraph-io/dgraph/pull/8294