dgraph fix(groot): do not upsert groot for all namespaces on restart (#7917)

Earlier, whenever the alpha starts(or restarts), we were upserting guardian and groot for all the namespaces. This is not actually needed. The change was made in the PR #7759 to fix a bulk loader edge case. This PR fixes that by generating the required RDFs in the bulk loader itself. Essentially, it inserts the ACL RDFs when force loading into non-Galaxy namespace.

Problem

Solution

Sep 19 '22 15:09 dshekhar95

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Sep 19 '22 15:09 CLAassistant

Coverage decreased (-0.001%) to 37.098% when pulling 8400af5ce69858bcb0e612d98d0fb1b8730001b9 on cherry-pick-7917_new into 9b670174e6af72b773ae59350d7fa3f75e91c80f on main.

Sep 19 '22 15:09 coveralls

There doesn't seem to be much test coverage for this. I found a thread that discusses issues with testing ACLs when they were first added: https://discuss.dgraph.io/t/acl-testing-findings/4920/3

@dshekhar95 Can you describe the testing that went into this?

Sep 23 '22 20:09 matthewmcneely

There doesn't seem to be much test coverage for this. I found a thread that discusses issues with testing ACLs when they were first added: https://discuss.dgraph.io/t/acl-testing-findings/4920/3

@dshekhar95 Can you describe the testing that went into this?

Hi Matthew... there is no testing for this. This is not a cherry-pick that I have high confidence in given the lack of a test here and lack of broader coverage as you pointed out

Sep 26 '22 18:09 dshekhar95

@dshekhar95 @meghalims & I decided to punt this for next release. Going to move this draft

Sep 29 '22 23:09 skrdgraph