Dmitry Markin

Results 46 issues of Dmitry Markin

Hope this may be helpful

## Description This is a follow-up PR to https://github.com/paritytech/substrate/pull/11938 to rename Polkadot request-response protocols similarly to Substrate changes, originally discussed in https://github.com/paritytech/substrate/issues/7746. ## Open questions This PR doesn't cover all...

A0-pleasereview
B0-silent
C1-low 📌

# Description `Listener` variant of `ConnectedPoint` is meaningless in `DialError::WrongPeerId`, so this PR replaces `ConnectedPoint` with `Multiaddr` (previously returned in the `Dialer` variant). ## Links to any relevant issues This...

## Description Change the [`endpoint`](https://github.com/libp2p/rust-libp2p/blob/62622a1bad70381e56237b4da4d9abcf2b1a0e24/swarm/src/lib.rs#L1444) type to `Dialer`, extracting it from [`ConnectedPoint`](https://github.com/libp2p/rust-libp2p/blob/62622a1bad70381e56237b4da4d9abcf2b1a0e24/core/src/connection.rs#L116). ## Motivation Currently in case of [`DialError`](https://github.com/libp2p/rust-libp2p/blob/62622a1bad70381e56237b4da4d9abcf2b1a0e24/swarm/src/lib.rs#L1423) with `WrongPeerId` the [`ConnectedPoint`](https://github.com/libp2p/rust-libp2p/blob/62622a1bad70381e56237b4da4d9abcf2b1a0e24/core/src/connection.rs#L116) is returned, which can contain `Listener`, which...

difficulty:easy
help wanted
getting-started

Resolves https://github.com/paritytech/substrate/issues/12267 and pulls in https://github.com/libp2p/rust-libp2p/pull/2846 to support fallback Kademlia protocol names (see https://github.com/paritytech/substrate/issues/7746). The main change is that `NetworkBehaviourEventProcess` was deprecated, so the event processing previously taking place in...

A3-inprogress
B0-silent
C1-low 📌
D3-trivial 🧸

### Is there an existing issue? - [X] I have searched the existing issues ### Experiencing problems? Have you tried our Stack Exchange first? - [X] This is not a...

### Is there an existing issue? - [X] I have searched the existing issues ### Experiencing problems? Have you tried our Stack Exchange first? - [X] This is not a...

I8-enhancement 🎁
P7-nicetohave
Q5-substantial

This is a follow-up to https://github.com/paritytech/substrate/pull/12971 & https://github.com/paritytech/substrate/pull/13020. As discussed in https://github.com/paritytech/substrate/pull/12971#discussion_r1063641102, it's desirable to set exact warning threshold on the unbounded channel queue size. The implementation relies on Release...

A0-pleasereview
B0-silent
C1-low 📌

Resolves https://github.com/paritytech/substrate/issues/6919. Re-does https://github.com/paritytech/substrate/pull/5704. I also tried rewriting `sc-network-test` to use async/await instead of polling, the first attempt is here: https://github.com/paritytech/substrate/commit/4b5d851ec864f78f9d083a18a618fbe117c896d2. It turned out that doing it without slowing down...

A0-pleasereview
B0-silent
C1-low 📌
D3-trivial 🧸

Resolves https://github.com/paritytech/substrate/issues/11922. ### Follow-up Things could be simplified further by removing `Message::Accept` and `Message::Reject` variants from [`sc_peerset::Message`](https://github.com/paritytech/substrate/blob/e055af136912a7b21ecd619d782c81e3281b8e58/client/peerset/src/lib.rs#L202-L225) and making [`Peerset::incoming()`](https://github.com/paritytech/substrate/blob/e055af136912a7b21ecd619d782c81e3281b8e58/client/peerset/src/lib.rs#L172-L176) return result synchronously. Unfortunately, this requires modifying `Notifications`, and as...

A0-pleasereview
B0-silent
C1-low 📌
D3-trivial 🧸