Dan Lawin

> Commenting to move this out of being stale. This is still a highly relevant feature that needs to be added. Yeah this should definitely remain open. I'm unsure if/when...

@mariahjrogers @koenvb which database providers are you encountering this with?

Context on why this is not supported yet: We currently support *certain* strings as PKs. They need to be alphanums with a fixed length (and only these characters) `-0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ_abcdefghijklmnopqrstuvwxyz` The...

In order to accomplish this we'll need to require the `--state` flag like dbt, and pass the location of that manifest along to the dbt package here: ``` File "/Users/dan/repos/demo/env/lib/python3.11/site-packages/data_diff/__main__.py",...

As a workaround before this is added, the `DBT_STATE` env var can be set to the folder with the "prod" manifest ``` ✗ export DBT_STATE=/Users/dan/repos/my_folder_with_prod_manifest ```

> As a workaround before this is added, the `DBT_STATE` env var can be set to the folder with the "prod" manifest > > ``` > ✗ export DBT_STATE=/Users/dan/repos/my_folder_with_prod_manifest >...

Seems like there may be an issue with the all_rows query [here](https://github.com/datafold/data-diff/blob/73226ee922f5e95abfabbf9deb63480bc97a68e6/data_diff/joindiff_tables.py#L333) They are passed into _materialize_diff [here](https://github.com/datafold/data-diff/blob/master/data_diff/joindiff_tables.py#L198)

@qsliu2017 ty for reporting this! There was an issue in `0.2.0` here https://github.com/datafold/data-diff/issues/616 We'll have to investigate/mitigate that if we bump the version up

> **Is your feature request related to a problem? Please describe.** > > We have tables that contain key columns with the type `Text()`. We can not change these columns;...

Context on why arbitrary strings are not supported (without some work) in #539 https://github.com/datafold/data-diff/issues/539#issuecomment-1773354733