data-diff icon indicating copy to clipboard operation
data-diff copied to clipboard

Databricks: support column of type `Text()` as key

Open JCZuurmond opened this issue 3 years ago • 10 comments

Is your feature request related to a problem? Please describe.

We have tables that contain key columns with the type Text(). We can not change these columns; we have to use the tables as is.

Describe the solution you'd like

I want to use columns with the type Text() as the key.

Describe alternatives you've considered

None. If this feature will/can not be supported, then I will see if can create views that convert the key columns to numeric columns.

Additional context

Running on Databricks

JCZuurmond avatar Dec 27 '22 10:12 JCZuurmond

This issue has been marked as stale because it has been open for 60 days with no activity. If you would like the issue to remain open, please comment on the issue and it will be added to the triage queue. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar May 14 '23 06:05 github-actions[bot]

👆

JCZuurmond avatar May 15 '23 05:05 JCZuurmond

Is your feature request related to a problem? Please describe.

We have tables that contain key columns with the type Text(). We can not change these columns; we have to use the tables as is.

Describe the solution you'd like

I want to use columns with the type Text() as the key.

Describe alternatives you've considered

None. If this feature will/can not be supported, then I will see if can create views that convert the key columns to numeric columns.

Additional context

Running on Databricks

Thanks for reporting this @JCZuurmond, we're not currently working on this but may in the future, in the meantime we'd happily accept a community contribution

dlawin avatar May 23 '23 17:05 dlawin

A similar issue has cropped up related to Databricks Date PKs:

ERROR - Cannot use a column of type UnknownColType(text='DATE') as a key

leoebfolsom avatar May 24 '23 23:05 leoebfolsom

This issue has been marked as stale because it has been open for 60 days with no activity. If you would like the issue to remain open, please comment on the issue and it will be added to the triage queue. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar Aug 14 '23 06:08 github-actions[bot]

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment and it will be reopened for triage.

github-actions[bot] avatar Aug 21 '23 06:08 github-actions[bot]

👆

JCZuurmond avatar Aug 21 '23 10:08 JCZuurmond

Running into the same issue.

ism21 avatar Oct 19 '23 21:10 ism21

Yes, same issue here... All columns we use have surrogate keys which are strings.

ferdyh avatar Nov 01 '23 15:11 ferdyh

Context on why arbitrary strings are not supported (without some work) in #539

https://github.com/datafold/data-diff/issues/539#issuecomment-1773354733

dlawin avatar Nov 01 '23 20:11 dlawin

Hi all -

I'm sorry for the delay in following up on this. @JCZuurmond, thank you for taking the time to raise this issue!

We made a hard decision to sunset the data-diff package and won't provide further development or support.

If that's of interest, over the past few months, we have rewritten the diffing engine in Datafold Cloud and solved many issues that existed in this package.

-Gleb

glebmezh avatar May 17 '24 13:05 glebmezh