Dominik Kriegner

Results 82 comments of Dominik Kriegner

> We're implementing a testing suite, with which you can test the communication protocol of your device. PR #634 contains the current work in progress. The tests do work, we're...

> We plan to make Instrument.ask call write+read of the instrument instead of calling Adapter.ask, because we want to have the whole "protocol logic" in these two methods: write and...

I have added a test to the mentioned file. Since the feature of mapping was only implemented in `Instrument.measurement` I limited the test to the a `measurement` property. In order...

I can not see how the latest CI run fail is related to this pull request... If I should merge main (which might be needed anyway to have the latest...

> I can not see how the latest CI run fail is related to this pull request... If I should merge main (which might be needed anyway to have the...

> We are nearly there, I think the main thing that's left is the `get_process` behaviour. thanks for the review. I think I will leave the `get_process` for you since...

As far as I can see `TelnetAdapter` is only used by the `AttocubeConsoleAdapter`. I think this could be also reimplemented using a different underlying adapter. I remember vaguely it was...

I am on: ``` # uname -a Linux 4.3.0-sabayon #1 SMP Wed Dec 16 22:02:39 UTC 2015 x86_64 Intel(R) Core(TM) i7-3537U CPU @ 2.00GHz GenuineIntel GNU/Linux # perl -v This...

@bruceravel Actually I should highlight that this was not a warning, but the only output I got! Only after removing the symlink I could get any output from the build...

``` $ perl -e 'use File::Find; print $File::Find::VERSION, $/' 1.27 ```