Daniel G. Krakowczyk

Results 158 comments of Daniel G. Krakowczyk

I'm not sure that I understand. fixtures are a very common part of test suites. fixtures should be tested though. The way I implemented this and imported in `conftest.py` is...

> [here](https://github.com/pre-commit/pre-commit/blob/main/testing/fixtures.py?rgh-link-date=2025-04-22T12%3A02%3A28Z) with combination [this](https://github.com/pre-commit/pre-commit/blob/main/tests/conftest.py?rgh-link-date=2025-04-22T12%3A02%3A28Z) Ah thank you for the comment, now I understand what you mean. This isn't a separate repository, it's a dedicated module. But as a side...

This PR might seem very overwhelming at first due to the massive changes in absolute lines of code. This is however due to git not being able to correctly capture...

Maybe I don't fully understand, but isn't this already possible with the `split()` method? EDIT: I don't think that the save method should include this functionality.

Because it conflates preprocessing with saving and breaks the single responsibility principle. That's why you won't find this feature in any other package (see `np.save()`, `pandas.to_csv()`, `polars.to_csv()`, etc.). What you...

Don't get me wrong, this is a very common processing task and I do think this functionality should be integrated in some way. However, I don't think that `Gaze.save()` will...

The `Gaze` object is much more intended to be a record than a full session. Not being clear on that part will lead to lots of issues. We may evaluate...

> ToDo: Add a test with previous saccades in events dataframe. Assure they are untouched after `map_to_aois()`. Forgot to ask about this in today's meeting: do you still want to...

I think improving the error message by adding info how to get such a column be best (e.g., via `pix2deg` or `pos2vel`). Running these methods automatically, has the downside that...

Thanks for writing the issue! I guess we should specify the signature of the new arguments before starting development. As a side note, the `Gaze.save_samples/events()` currently doesn't provide a way...