Daniel G. Krakowczyk

Results 158 comments of Daniel G. Krakowczyk

> What do you think about ignoring these warnings for `parse_eyelink()`? I'm perfectly fine with the ignore for now. I think it hints at greater design issues of the `parse_eyelink()`...

> @dkrako > > > Judging from the event detection methods, the offset of an event is defined as the first sample that is not in the event any more....

> @dkrako I'm wondering whether it's actually useful at all to think about samples as having a "length". If we define a sample as a single point in time, I'd...

Although you're right that samples are only defined for a single time step and don't have any length, the measurement window to acquire a sample does have a length as...

The first paragraph of my comment is probably irrelevant or maybe even wrong. The remainder of the comment is what's important though (starting with the overestimate/underestimate) and there it is...

To further clarify as this is important to understand when we're working with event duration on this low level: Abstract from the eye tracker and the preprocessing and view the...

> I agree that it makes sense to have the duration match between between EyeLink and pymovements. But whether we add `1/sampling_rate` to the `offset` or subtract it from `onset`...

As discussed in #1019 I'm not much in favor of this anymore. It would add a lot of arguments to the basic synthetic functions. Initializing the corresponding `GazeDataFrame` could be...

the errors in the examples sections probably won't matter much after finishing #914