Daniel G. Krakowczyk
Daniel G. Krakowczyk
pylint is complaining: ``` src/pymovements/dataset/dataset_library.py:81: [E0213(no-self-argument), DatasetLibrary.names] Method 'names' should have "self" as first argument ``` This one would be easy to fix: either rename `cls` to `self` or ignore...
Probably the easiest next step will be to pass the parsed blinks as an `EventDataFrame` to the `GazeDataFrame.__init__()`. The dataframe will need the three columns: `name`, `onset`, `offset`. The `name`...
#1082 would get rid of the `data_loss_ratio` and `data_loss_ratio_blinks` fields in the metadata dict.
Unfortunately there can be multiple validations per calibration, so it's not possible to simply merge calibrations and validations into a single dataframe. We therefore need a `calibrations` and `validations` field...
Thanks! To add some further notes: the call of `unnest()` in `Gaze.map_to_aois()` results in unexpected side-effects and should be removed. `TextStimulus.map_to_aois()` should get the unnested `location` column name and the...
> * [ ] Add shortcut property to filter fixations, saccades, and blinks (as proposed in [Added Parsing Of BlinksFrom ASC To Data Frame #942 (review)](https://github.com/aeye-lab/pymovements/pull/942#pullrequestreview-2610335217)) I created #968 for...
> > I would probably leave it there for backwards compatibility and remove it when removing utils.parsing as planned in #973 > > @dkrako Does this mean that we should...
regarding your comment in our minutes: > the only thing left to decide is how to handle EyeLink's weird way of calculating event durations (https://www.sr-research.com/support/thread-9411-post-36595.html); should we use EyeLink's onset/offset...
> For `EventDataFrame`s, it doesn't seem as straightforward, judging by the number of failing tests... I didn't look through all the failing tests, but most tests failed on the expected...
> For now, another option would be to use `Float64` for `onset`, `offset`, and `duration` by default, and convert each of them back to `Int64` if possible, as it's done...