Dhruv Paranjape
Dhruv Paranjape
spoiler alert it seems it does work as expected 👍
Hello maintainers 👋 (I think @LeFnord ) could you help re-run the specs ? they do execute successfully locally but I have no idea what's happening with the CI
@LeFnord I disabled the fail fast setting and it seems that most of the matrix passes except the head version which fails because of `Your Ruby version is 3.2.0.dev, but...
fixed in #927
hello maintainers (@LeFnord)👋 could this be reviewed please ? is it worth merging ?
>please can you add a CHANGELOG entry and a [Routes Configuration](https://github.com/ruby-grape/grape-swagger#routes-configuration-) entry in the README, thanks added documentation to the README and CHANGELOG entry.
doesn't seem to break existing tests ``` d.paranjape@d grape_logging % bundle exec rspec /Users/d.paranjape/.rvm/gems/ruby-2.7.5/gems/rack-3.0.0/lib/rack/auth/digest.rb:8: warning: Rack::Auth::Digest is deprecated and will be removed in Rack 3.1 .................................. Finished in 0.06105 seconds...
>mmh, grape-entity is a presenting layer, so the data should be valid before it will be presented While I tend to agree. In the case of `grape-entity` the entity is...
>Does params: API::Entities::Status.documentation not expose those parameters with validation (Grape has extensive support for that)? And yes, validation would be definitely very useful if the above doesn’t work. When used...
>When used with grape I’d want to rely on its type checking mechanisms for consistency. could you elaborate how this would work 🤔