grape-swagger icon indicating copy to clipboard operation
grape-swagger copied to clipboard

Add Support for default response.

Open dhruvCW opened this issue 3 years ago • 2 comments

add support for default as a response code as specified in https://swagger.io/docs/specification/2-0/describing-responses/ Default Response section.

thus allowing for specifying a model that corresponds to all http status codes that are not specifically mentioned.

dhruvCW avatar Aug 21 '22 14:08 dhruvCW

Hello maintainers 👋

(I think @LeFnord ) could you help re-run the specs ? they do execute successfully locally but I have no idea what's happening with the CI

dhruvCW avatar Aug 24 '22 12:08 dhruvCW

@LeFnord I disabled the fail fast setting and it seems that most of the matrix passes except the head version which fails because of Your Ruby version is 3.2.0.dev, but your Gemfile specified 3.2.0

I have no idea if this is something that can be fixed quickly perhaps we can remove the head version from the matrix for now and create an issue with the github action ? so as to enable the CI and merge the PRs that are open.

dhruvCW avatar Aug 28 '22 13:08 dhruvCW

hello maintainers (@LeFnord)👋

could this be reviewed please ? is it worth merging ?

dhruvCW avatar Feb 27 '23 13:02 dhruvCW

first thanks @dhruvCW …

please can you add a CHANGELOG entry and a Routes Configuration entry in the README, thanks

LeFnord avatar Feb 27 '23 14:02 LeFnord

and yeah … your PR is very welcome :)

LeFnord avatar Feb 27 '23 14:02 LeFnord

please can you add a CHANGELOG entry and a Routes Configuration entry in the README, thanks

added documentation to the README and CHANGELOG entry.

dhruvCW avatar Mar 17 '23 11:03 dhruvCW

thanks @dhruvCW

LeFnord avatar Mar 19 '23 12:03 LeFnord