Daniel (dB.) Doubrovkine

icon indicating a website link https://code.dblock.org icon indicating an email [email protected]

icon company @opensearch-project icon location New York, NY icon location @opensearch-project, ex-@aws, former CTO @artsy @ArtsyOpenSource, @vestris, active maintainer of @ruby-grape, hashie, @slack-ruby, @playplayio and more.

Results 3352 comments of Daniel (dB.) Doubrovkine

How to define multiple allowed types when one of them is array of hash?

@jcagarcia Thanks. Before we close we should be sure that 1) it was broken when the bug was reported (whichever version shipped last by Jan 14, 2021), 2) that we...

Explicit parameters only

@timjnh asked for this feature again in #2358, anyone wants to try to take it on?

local scope variables are not available inside rescue_from

Thanks for the detailed explanation! I don't love copying instance variables at all because modifying them will not work across copies, so I think fixing `self` is the way to...

Added test for failing nested given validation

Yep, closing with https://github.com/ruby-grape/grape/pull/1811.

An incorrect behavior of :rescue_from

Thanks for the deep dive! If you compare this behavior with `version`, then it looks different: a `version` declaration in `AuthController` would take precedence over the declaration in `PublicApi`, won't...

An incorrect behavior of :rescue_from

I think you're completely correct on all the points above. So, is the problem in this issue correctly formulated or do we need to edit it? What's the tl;dr of...

An incorrect behavior of :rescue_from

I renamed this to "Change behaviors of rescue_from to not depend on mount order", lmk if this can be improved. > So my question now is... do we want to...

An incorrect behavior of :rescue_from

Maybe @wowinter13 wants to try it out from HEAD?

Still having issues with helper inheritance

Still looking for someone to pickup this issue and write some (failing) specs to start!

Still having issues with helper inheritance

Thanks for the repro! I bet `mount` copies/wires up a lot of things and helpers aren't one of those things. Hope you/someone can narrow it down and fix it!