Daniel (dB.) Doubrovkine

icon indicating a website link https://code.dblock.org icon indicating an email [email protected]

icon company @opensearch-project icon location New York, NY icon location @opensearch-project, ex-@aws, former CTO @artsy @ArtsyOpenSource, @vestris, active maintainer of @ruby-grape, hashie, @slack-ruby, @playplayio and more.

Results 3352 comments of Daniel (dB.) Doubrovkine

Telling a representer to represent nil adds all of that class's methods to nil

I'm interested in this (I work with @joeyAghion here :)) - I think the next step should be to properly spec it, @mach-kernel do you think you understand this enough...

Pass in initial admin password and remove admin:admin references

> @VachaShah I believe those tests are run against 2.x OpenSearch **without** security, so thus we are not seeing those fail yet. Are you able to help enable that?

Pass in initial admin password and remove admin:admin references

@DarshitChanpura also needs a rebase, please

Pass in initial admin password and remove admin:admin references

tests without security are still failing

[FEATURE] allow setting an arbitrary json property on any level of any API request objects

Looks right, want to contribute @L00kian ?

[FEATURE] allow setting an arbitrary json property on any level of any API request objects

Both! I think that arbitrary fields support on all the levels makes some sense because it will provide a workaround quickly, but that also means that one could theoretically add...

[FEATURE] Rewrite this client in TypeScript

@nhtruong This LGTM. I'd call the branch `feature/typescript-conversion` per convention with other repos.

Delegate to Roar's represent w/o options argument

I like this change. It needs documentation, tests, and a CHANGELOG entry. You should fix the build too, use `rbx-2` in .travis.yml and add it to `ignore_failures`.

Delegate to Roar's represent w/o options argument

Hmmmm, this is kinda a big deal. I've seen this kind of usage in many places, I definitely use it all over the place, like [here](https://github.com/dblock/slack-amber-alert/blob/master/slack-bot-server/api/endpoints/teams_endpoint.rb#L29). I guess the question...

Delegate to Roar's represent w/o options argument

I don't think we want an array of hypermedia representations. A lot of times you want other fields in there, such as `total_count`, for example. How would I do that?...