Daniel (dB.) Doubrovkine

icon indicating a website link https://code.dblock.org icon indicating an email [email protected]

icon company @opensearch-project icon location New York, NY icon location @opensearch-project, ex-@aws, former CTO @artsy @ArtsyOpenSource, @vestris, active maintainer of @ruby-grape, hashie, @slack-ruby, @playplayio and more.

Results 3352 comments of Daniel (dB.) Doubrovkine

[BUG] Range queries are inconsistent with documentation

Is this fixed/changed in main? Or with opensearch-java?

[BUG] Range queries are inconsistent with documentation

@prudhvigodithi If @reta is correct, is this still an issue? I do feel like if I use `gte` I'd expect to see `gte`, and if I use `to` I'd expect...

[BUG] Missing Required Property `Builder.<variant kind>`

Let's leave Elastic aside. It's likely the same bug. Feel free to turn it into a failing unit/integration test and make a PR with a fix. Please make sure not...

[BUG] Async model usage needs to import private `_async` module

Yes, this looks incorrect. Would appreciate a PR. Are there other types in this case? Does anything have to be `_async`?

[BUG] Async model usage needs to import private `_async` module

Thanks for pointing this out @drewbrew. I guess I don't know the answer to this, let's work backwards from what we want?

[BUG] Async model usage needs to import private `_async` module

@pattrickrice Is this based on the code duplication? Much of it is generated, or should be, so I'd start by deleting all the API implementations and focusing on a new...

[BUG] When using AWSV4SignerAuth with AsyncOpenSearch, providing "id" to `index` or `delete` breaks the signature

Try turning it into a failing test? This is generally a symptom that the payload signed doesn't match the payload sent.

Telling a representer to represent nil adds all of that class's methods to nil

This is happening [here](https://github.com/ruby-grape/grape-roar/blob/master/lib/grape/roar/representer.rb#L10), maybe we should protect the code from extending singletons, `nil` being one, maybe there's a better way than comparing to a list? Also is there any...

Telling a representer to represent nil adds all of that class's methods to nil

Maybe we can just detect whether these are singleton types and make them non-representable?

Telling a representer to represent nil adds all of that class's methods to nil

@ashkan18 was this your problem?