Daniel (dB.) Doubrovkine
Daniel (dB.) Doubrovkine
> Next Grape release is `2.1.0` and `Grape` is still `ruby >= 2.7.0`. Should they follow each other related to `ruby` version ? I don't think they have to. Generally...
The code looks good here. I think we still need to say something in UGPRADING/README about auto-loading? WDYT? It feels like a scary change to go "quietly" :)
@ericproulx Want to add some words to those files and let's merge?
Merged, nice work.
Definitely a yes on documentation, please PR! We could probably improve the error here. It is trying to coerce a symbol and you get a `SymbolCoercer` error. While `type: :identifier_type`...
1. Does it work if `type` is not an array (e.g. `String`)? 2. Does it work without `given`? 3. Confirm the version of Grape and Rack, could be related to...
What's the upgrade path for someone using `Rack::Auth::Digest`? Is there a GitHub issue on removing it somewhere that explains why? For grape this sounds like a breaking change either way....
> Want me to make a PR? Yes please!
Does `params[:foo]` work? If not this is a great feature request. Note that circular dependencies might become possible 🤔
This is a lot better! Can we apply this to at least some minimum number of requests, not just put index template? I'd also love a guide (maybe copy from...