Daniel (dB.) Doubrovkine

Results 3350 comments of Daniel (dB.) Doubrovkine

You correctly point out that we have [`error!`](https://github.com/ruby-grape/grape/blob/76cae5981900922d13bd8bfff53389e7dd66d90d/lib/grape/dsl/inside_route.rb#L164) that behaves this way by raising an exception. I don't think an alias to `halt!` is needed, but is there a scenario...

First, thank you. I (we) are open to suggestions and we absolutely should discuss it. Adding an API is a big deal so expect push back, but if you believe...

Good points. I think `success!` could be a good idea semantically, but it would need to throw an exception to abort flow, so it's weird that internally we raise an...

It's a good idea. It could just be an extension to `params` that takes a `Dry::Validation::Contract`, and yes we could alias `params` to `contract` too. I'm thinking one would want...

I love the idea of `contract do ...`. Do you think it's possible to refactor `params do ...` (`ParamsScope`) in a way that can be fully swapped by your implementation...

We should put the implementation aside for a second, and only talk DSL and user-facing behavior, it will make things easier. I'd be curious to hear from @dnesteryuk (added dry-types)...

Good discussion and everything you said makes a lot of sense! Want to try a PR that introduces basic functionality that lets one switch between existing `params` and contracts? I...

What's the downside?

Rebase? I'll take a look.

> There's a breaking change with custom validator. Now, they must follow the convention `Grape::Validations::Validators::[CustomName]` The registration part was done through inheritance. I'll put it back. Sounds good, I'll wait...