Daniel (dB.) Doubrovkine comments

Results 3356 comments of


                                            Daniel (dB.) Doubrovkine

Recognize_path should account for HTTP method

Indeed. I am actually kinda surprised it doesn't. Start by writing a spec that (fails to) differentiate(s) multiple methods on the same API. What do we return today? The first...

Route#options and Route#settings are confusing

Eh, this is indeed confusing. I like both suggestions, would start with internal values, moving those should probably not break specs.

custom type not suppot multiple types, raise `Grape::Exceptions::ValidationErrors`

Looks like a legit bug. > If this is correct, I can create a PR to fix it. Please!

Param with multiple acceptable Hash Types

I can't believe we don't support this today! I think it's a new feature request. One other idea of how we could express this is by allowing duplicate keys, but...

Param with multiple acceptable Hash Types

> Or do we want to avoid having custom types and you want to be able to define `Hash` with specific properties directly when defining params? I think it overcomplicates...

Do not overwrite route_param with a regular one if they share same name

@arg want to finish this?

Do not overwrite route_param with a regular one if they share same name

@DmytroVasin thanks for the deep dive, makes sense, let's get this PR finished and make sure we have the right specs - is there anything else missing here?

Do not overwrite route_param with a regular one if they share same name

I think so, basically what I said in https://github.com/ruby-grape/grape/pull/2378#pullrequestreview-1748045405. Thanks for picking this up!

Do not overwrite route_param with a regular one if they share same name

@DmytroVasin want to finish this PR for @arg?

Do not overwrite route_param with a regular one if they share same name

Thanks for the good work and for hanging in here with my OCD!