David Verdú
David Verdú
In a first look addressing the tests and documentation, I have commented some lines of the codes pointing out issues about naming of functions. Maybe I'm being a bit nitpicky,...
/integration sha=393fade
/integration sha=393fade
Hello. You need to create a changeset file and commit it to let this change be approved. Could you run `rush change` and commit the generated file? This is the...
/integration sha=6126df160824fe5d0b7bfebb7a66205c51989f4b
/integration sha=e8118736d4012188d07342b366beb2cf5317a3ea
Hi @Virajjai this is a solo test but you are not adding any feature on this PR. When I generate a new project, the file `.vscode/launch.json` is not being generated....
nonetheless @nicolas-scheers-lemon , you also need to add the changeset file. Please run `rush change` and commit the changeset file
Hi @nicolas-scheers-lemon @hendrik-depauw-lemon the PR is approved. However, you need to solve the conflicts, for example, by rebasing. Could you do that?
/integration sha=cca4d47