booster icon indicating copy to clipboard operation
booster copied to clipboard

Graphql union types for queries

Open nicolas-scheers-lemon opened this issue 1 year ago • 1 comments

Description

Changes

Checks

  • [x] Project Builds
  • [x] Project passes tests and checks
  • [ ] Updated documentation accordingly

nicolas-scheers-lemon avatar Oct 09 '24 15:10 nicolas-scheers-lemon

/integration sha=a76305e

nicolas-scheers-lemon avatar Oct 22 '24 08:10 nicolas-scheers-lemon

/integration sha=ab07fed

nicolas-scheers-lemon avatar Oct 24 '24 15:10 nicolas-scheers-lemon

Hey @javiertoledo, have you had the time yet to take a look at this PR? Thanks in advance!

hendrik-depauw-lemon avatar Nov 07 '24 16:11 hendrik-depauw-lemon

Hey @javiertoledo, can I bump this PR? 🙂

hendrik-depauw-lemon avatar Nov 21 '24 12:11 hendrik-depauw-lemon

nonetheless @nicolas-scheers-lemon , you also need to add the changeset file. Please run rush change and commit the changeset file

davidverdu avatar Dec 02 '24 17:12 davidverdu

@davidverdu I addressed your comments and added the changeset file

nicolas-scheers-lemon avatar Dec 08 '24 21:12 nicolas-scheers-lemon

Hi @nicolas-scheers-lemon @hendrik-depauw-lemon the PR is approved. However, you need to solve the conflicts, for example, by rebasing. Could you do that?

davidverdu avatar Dec 11 '24 13:12 davidverdu

@davidverdu I solved the conflict

nicolas-scheers-lemon avatar Dec 13 '24 13:12 nicolas-scheers-lemon

/integration sha=cca4d47

davidverdu avatar Dec 13 '24 16:12 davidverdu

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Dec 13 '24 16:12 github-actions[bot]

:white_check_mark: Integration tests have finished successfully!

github-actions[bot] avatar Dec 13 '24 17:12 github-actions[bot]