David Gumberg

Results 16 issues of David Gumberg

Switch manual byte conversion to htole in mkfs.fat.c Corrected #128, still learning git and doing some stupid repo deletion, commit squashing stuff.

The first example (Native P2WPKH) signature in BIP 143 was missing a SIGHASH flag. The signature scheme requires a DER encoded signature with a one-byte SIGHASH/'hash type' flag appended. (Excepting...

Interpolated `Time`'s and `Date`'s should respect default formatting options and locale. Rails, [for example,](https://github.com/rails/rails/blob/2c8428c78aeced2af089facb6d41234896b6e847/activemodel/lib/active_model/error.rb#L15-L62) passes `Date` and `Time` ActiveRecord attributes to `I18n::t`. (This may also avoid triggering some deprecation warnings...

This PR allows users of the `lncli` RPC interface to set the `min_final_cltv_expiry_delta` described in BOLT's [11](https://github.com/lightning/bolts/blob/master/11-payment-encoding.md#tagged-fields), [7](https://github.com/lightning/bolts/blob/master/07-routing-gossip.md#tagged-fields), and [2](https://github.com/lightning/bolts/blob/master/02-peer-protocol.md#cltv_expiry_delta-selection) by setting the `cltv_expiry` flag when calling either `addinvoice` or...

As far as I am aware, ERB Syntax permits an embedded ruby comment in a non-comment erb tag ```erb ``` But, once the treesitter encounters a mid-embedding comment, it evaluates...

This PR improves subtree exclusion by rewriting lint checks to reuse common exclusion logic. Most lint checks previously did not exclude `crypto/ctaes`, the locale linter did not exclude `src/crc32` Makes...

Tests
Needs rebase

Modifies the summary printed at the end to be entirely in stdout instead of mixed between stderr and stdout. Without this commit, suppressing stdout output or capturing stderr output for...

On some systems, the default `nofile` limit is below elastic's minimum of 65536. This causes elastic search to fail during its bootstrap check. This PR sets a `nofile` limit of...

This PR modifies `DataStream`'s byte-vector `vch` to use the default allocator `std::allocator` rather than the `zero_after_free_allocator` which degrades performance greatly. The `zero_after_free_allocator` is identical to the default `std::allocator` except that...

Utils/log/libs
Resource usage

Fixes #31744 Reuse `secure_allocator` for `AES256_ctx` in the aes 256 encrypters and decrypters and the `iv` of `AES256CBC` encrypters and decrypters. These classes are relevant to `CCrypter`, used for encrypting...

Utils/log/libs