David Gumberg
David Gumberg
:+1: any more work @jbladen ? It'd be incredible if this was fixed
I believe those casts are unnecessary, but I included them in case I don't fully understand something about ``htole``
Sorry fstirlitz, I failed to understand your first comment. Let's say the struct wasn't packed. What would be the problem with this PR? Where is the unaligned memory access?
I will rebase later tonight, I have not looked in a long time but I think I missed a spot in this PR Sent from my iPhone > On Jan...
@pali Rebased! Sorry, about that, must have fallen asleep.
any issues i could work on to resolve this?
ACK https://github.com/bitcoin/bips/pull/1510/commits/3671465ce62f91c6e115ec870b2b66e91b0cac43
@luke-jr Already fixed in #724.
ACK https://github.com/bitcoin/bips/pull/676/commits/0aedaf07aac9b38aed8be7f51240a41e4de76a39