Dave Kay

Support for calling Ether Balances in mappings

3

Right now there is no way to call an ether balance of an account or a contract. This functionality is very useful in protocols that use ether - this includes...

We have governor public, and a getter called getGovernor

5

We have on `Controller`: ``` address public governor; ``` and ``` /** * @notice Getter to access governor */ function getGovernor() external override view returns (address) { return governor; }...

https://github.com/graphprotocol/compound-v2-subgraph/pull/10 @juanmardefago put together this PR, and pointed out that the price oracle for compound is a bit messy. It could use a refactor. Next time we update this, we...

Move helpers from contracts to common-ts

1

The function here: https://github.com/graphprotocol/contracts/blob/master/scripts/contracts/connectedContracts.ts Can be moved here. I think the simple function like staking are probably duplicated and can be removed. But this is what I think is valuable:...

Subgraph does not contain the GraphProxyAdmin address

2

I forgot to add it as it was a late add to the protocol. We should index it and add it to `GraphNetwork.proxyAdmin`

Getting total claimable tokens in the network

1

This is not implemented right now, under `graphNetwork.totalClaimableTokens` . However, it could be roughly implemented by doing: - when a pool gets claimed for the first time, we know all...

Open question about calculating total values for the Subgraph Entity

1

Values such as: - totalIndexingRewards - totalQueryFeesCollected - totalStake - totalSignal Are ignored in the subgraph for now. Since 2 subgraphs can point to the same existing subgraph deployment. It...

TODOS for organization, improvements, processes and documentation

2

**Organization** - [x] Remove all fields that are not implemented, or label them NOT IMPLEMENTED - [x] Clean up the schema - [ ] Clean up all the mappings and...

- [ ] Truncate decimals on division for values like GRT. GRT with 18 decimal places cannot have decimals after. They do not exist on the blockchain, it is pointless...

Add JSON utils for returning kinds, valid utf8, and kinds to strings

1

Found these here: https://github.com/nanspro/kauri-subgraph/blob/master/src/util.ts - Untested. Opening the PR to make us aware of it - I am found of them all, except `kindToString()` - not too sure if this...