graph-ts icon indicating copy to clipboard operation
graph-ts copied to clipboard

Add JSON utils for returning kinds, valid utf8, and kinds to strings

Open davekay100 opened this issue 5 years ago • 1 comments

Found these here: https://github.com/nanspro/kauri-subgraph/blob/master/src/util.ts

  • Untested. Opening the PR to make us aware of it
  • I am found of them all, except kindToString() - not too sure if this is useful enough to be in the library
  • isValidUTF8() looks great, but I am unaware of how it currently works
  • Would be nice to add in for asBigInt() and asI32()

What do you guys think? @Jannis @leoyvens

davekay100 avatar Jun 08 '20 00:06 davekay100

The as* APIs for JSON seem useful, but they should be put directly under JSONValue.

leoyvens avatar Jun 10 '20 14:06 leoyvens