Daniel Norris

Results 10 issues of Daniel Norris

Fixes https://github.com/IzzelAliz/Arclight/issues/627 (tested by @nicholasrobertm and confirmed to work)

This PR is a continuation of the conversation from https://github.com/MinecraftForge/MinecraftForge/pull/9675. ## Reason The main reason I initially wanted to be able to modify the entity's push reaction was to prevent...

Needs Rebase
Triage
1.20

Removes the phase variable in the TickEvent class and changes all the sub classes to have Pre/Post classes, as mentioned in [here](https://gist.github.com/PaintNinja/4d1a35c03b377e78a74c708184ce893e#forge) Theoretically this would give a **minor** performance boost...

BreakingChange
Assigned
1.20

Adds checks to prevent the OnlyIn annotation being used in erroneous places such as classes annotated with the `@Mod`, or `@EventBusSubscriber` as outlined [here](https://gist.github.com/PaintNinja/4d1a35c03b377e78a74c708184ce893e#forge)

Triage
1.20

Adds, and migrates all references, to the IEvent interface to allow creating record based events in the future. I'm not sure if this was the correct way to do this,...

The reason for this change is that if you connect to a modded server on a proxy, and then go back to a vanilla/spigot server, the Forge client still thinks...

Bug
Assigned
1.20

The reason I made this is because when a mod adds a custom RecipeBookType, and then attempts to connect to a vanilla server they get disconnected as it's attempting to...

Triage
1.20

Requires https://github.com/MCXboxBroadcast/sctp4j/pull/1 But I believe that using the "ThreadedAssocation" class it creates two new threads per connection request currently. Therefore, changing the class to the CachedThreadedAssocation should prevent that and...

The enum `FireworkExplosion.Shape` no longer implements `IExtensibleEnum` which means you can no longer add custom firework shapes into the game. The rest of the logic appears to still be in...

1.21

The RenderGuiEvent no longer exists in this version, and is commented out with the comment at the top stating "Removed, Mojang created a layered rendering system that should make this...

Triage
1.21