Daniel Norris

Results 6 comments of Daniel Norris

Sorry you're saying it was not accepted? https://github.com/PaperMC/Velocity/pull/690#pullrequestreview-943904486 To be quite frank your entire attitude to this PR has been disgusting from the start @electronicboy. I've seen private comments made...

[Here](https://i.gyazo.com/7b82c05f94bdd42717cac0bfbbfdf651.mp4) is a GIF of the cow and player interactions from the test mod

> Throw some bin compat bouncers with `@Deprecated(forRemoval = true, since = "1.20.4")` and pull. Few other notes, May be worth reformatting the event class to braces on same line...

> Yes doing so would allow it to be pulled in 1.20.4, however with 1.20.5 coming here soon it doesn't matter. Alright I've rebased it for latest versions & added...

> Thanks for your PR. Did a quick code review on my phone, looks good. Assigning to Lex for further testing. > > In terms of performance, I expect record...

> Ya that's my main concern unfortunately, we still have to use the first intention packet to inform the other side of the connection what all to expect in the...