Dan J Miller comments

Results 98 comments of


                                            Dan J Miller

[Bug]: Message: f.getNativeCurrency(...) is undefined Code: TypeError

We will be shipping a fix soon, but in the meantime the only fix is to uninstall and re-install your metamask. If you do that, make sure your seed phrase...

Add entry point for metalabs dapp into metamask home page

@rachelcope This recording shows the designs / UX (the portfolio dapp doesn't render because the site is not live yet, but you can see the MetaMask experience). Does it look...

Fix/use etherjs specific imports

> Looks like the interfaces haven't changed for the functions/objects we use @adonesky1 I agree. I don't think updating will be breaking for us

Metamask freezes when trying to confirm transaction on Trezor T

Thanks for the report. Was this on the ethereum mainnet network?

Reduce size of lib p2p and its related modules

Let's check if this is still needed after #14928 and #14888 are resolved. We can treat those as blockers for this.

MV3: add retry logic to actions

Progresses #14853

We don’t need all seed phrase word lists (only english)

Duplicate of #15022

Migrate to one bip39 package. We use multiple right now, ethers and bip39, both of which have their own wordlists

- [ ] Identify all places in our dependency tree that have some version of bip39 as a dependency - [ ] figure out how to standardize them

Migrate to one bip39 package. We use multiple right now, ethers and bip39, both of which have their own wordlists

@rekmarks MetaMask currently uses https://github.com/MetaMask/bip39, a fork of https://github.com/bitcoinjs/bip39. I believe this fork was needed to support one of the security fixes to https://medium.com/metamask/security-notice-extension-disk-encryption-issue-d437d4250863 Should we all use that one?...

Migrate to one bip39 package. We use multiple right now, ethers and bip39, both of which have their own wordlists

2 options: 1. research alternatives to bitcoinjs/bip39 that can meet the needs of our fork but are better maintained. Whatever alternative we use, we might need to get them to...