metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Metamask freezes when trying to confirm transaction on Trezor T

Open Fefiox opened this issue 4 years ago • 40 comments

When trying to confirm the transaction after giving access to metamask to my trezor T wallet, it freezes and doesn´t continue, freezing also the browser.

Steps to reproduce (REQUIRED) Steps to reproduce the behavior, libraries used with version number, and/or any setup information to easily reproduce:

  1. Make a transaction
  2. Opens a new page where metamask asks for permission to confirm the transaction on the Trezor T
  3. Give access
  4. When the page closes and the transaction should appear to confirm on the Trezor, nothing happens and the app freezes.

Expected behavior Confirm the transaction on the Trezor T.

Browser details (please complete the following information):

  • OS: Windows
  • Hardware Wallet: Trezor Firmware version 2.4.2
  • Browser: Firefox
  • MetaMask Version:10.6.4

Fefiox avatar Dec 03 '21 18:12 Fefiox

Thanks for the report. Was this on the ethereum mainnet network?

danjm avatar Dec 03 '21 20:12 danjm

It was on Avalanche mainnet, but it happens in all of them.

Fefiox avatar Dec 04 '21 00:12 Fefiox

This is most probably a duplicate of https://github.com/MetaMask/metamask-extension/issues/12130

prusnak avatar Dec 04 '21 00:12 prusnak

U uthe

Sukha5911 avatar Dec 05 '21 04:12 Sukha5911

Same problem, waiting for fix.

Einoow avatar Dec 09 '21 12:12 Einoow

Hey! Any update about this problem?

Browser details (please complete the following information):

OS: Windows Hardware Wallet: Trezor model one Firmware version 1.10.3 Browser: Firefox MetaMask Version:10.8.0

Einoow avatar Dec 21 '21 13:12 Einoow

Hardware Wallet: Trezor model one Firmware version 1.10.3

@Einoow the issue has been fixed in Metamask 10.8.0 but you need to update your firmware to version 1.10.4

prusnak avatar Dec 21 '21 13:12 prusnak

Hey! Thanks for your response, I have made some tests and seems like the problem is still there for me.

OS: Windows Hardware Wallet: Trezor model one Firmware version 1.10.4 Browser: Firefox MetaMask Version: 10.8.1

Einoow avatar Jan 03 '22 17:01 Einoow

Same problem. Anyone know how to fix it?

bitblock-01 avatar Jan 11 '22 06:01 bitblock-01

Same problem. Anyone know how to fix it?

Still waiting, hope they fix it in the next update

Einoow avatar Jan 22 '22 10:01 Einoow

Experiencing the same issue

Browser details (please complete the following information): OS: Windows Hardware Wallet: Trezor model one Firmware version 1.10.5 Browser: Firefox MetaMask Version: 10.8.1

Zenitsu227 avatar Jan 25 '22 10:01 Zenitsu227

same problem as above...also had this problem a few weeks back and tried reinstalling firmware on trezor multiple times and it just started working. cant confirm that firmware was the problem as I tried this multiple times before having any success. this problem just started again last night. has anyone found a solution?

Smileez1234 avatar Feb 03 '22 16:02 Smileez1234

I also tried restoring the wallet from a new device (metamask no problem) but when importing the hardware wallet from metamask, it brings up a list of wallets to import, none of which is the address I am looking for.

Smileez1234 avatar Feb 03 '22 16:02 Smileez1234

This issue is so annoying. Happens almost every day. Is this being resolved?

ryny24 avatar Feb 08 '22 05:02 ryny24

I have checked the new update and it is still happening to me

Einoow avatar Feb 11 '22 02:02 Einoow

Still happening to me in 10.9.2

PabloCastellano avatar Feb 12 '22 16:02 PabloCastellano

Also having the issue.

OS: Windows Hardware Wallet: Trezor model T Firmware version 2.4.3 Browser: Chrome MetaMask Version: 10.9.2

Is there anything else helpful people could provide to help fix this issue? A way to collect logs or something that we could attach here? I found the "download state logs" option under settings > advanced, but I can't get to it or activate it once I've gone through the steps that cause it lock up.

It doesn't appear to happen for every site or every action, but it does seem to be repeatable 100% of the time for certain sites and certain actions.

Current steps I use to reproduce:

  1. Navigate to kogefarm.io/vaults
  2. Connect MetaMask to the site (Polygon).
  3. Attempt to approve the Kogecoin vault.
  4. Sometimes it freezes at this point when clicking "approve".
  5. Otherwise, the Trezor window pops up to request passphrase, after which it freezes.

Currently I have both a standard hot wallet, and my Trezor-linked walled in MetaMask. Hot wallet seems to have no problems.

EDIT: Looks like I was able to get it to lock up simply by trying to send Matic from my HW to Hot wallet within MM.

Relic180 avatar Feb 15 '22 15:02 Relic180

Thanks for your comments. @bitblock, @Smileez1234, @ryny24, @PabloCastellano are you also using Windows OS here? I'm trying to figure out the commonalities.

AlexJupiter avatar Feb 17 '22 19:02 AlexJupiter

@AlexJupiter Nope, I'm using Linux Mint. Not sure if it's a commonality but when I have hit this issue I was using the Polygon network, and it worked for other networks intead.

PabloCastellano avatar Feb 17 '22 20:02 PabloCastellano

In my case I cannot get to swap on Polygon. I've tried with different RPCs but no luck.

@AlexJupiter Could you try the following use cases? This is what I'm seeing:

In uniswap (https://app.uniswap.org/#/swap?chain=polygon), the prices keeps updating all the time and I cannot click "Confirm" to initiate the swap tx.

In 1inch (https://app.1inch.io/#/137/swap/USDT/MATIC): when I want to approve the smart contract for the token I want to trade, a metamask popup appears and I click to confirm signing the transaction, but metamask (and firefox at some sort) freezes.

PabloCastellano avatar Feb 19 '22 15:02 PabloCastellano

Are there any details on this? Is it something that is actually going to get fixed?

I just recently added my Trezor T to Metamask and turns out that probably +80% of the actions I try to take are locking up the wallet, INCLUDING sending funds that I transferred from my hotwallet, back to my hotwallet in an attempt to just get unblocked.

Recently tried to execute a swap on bogged.finance, and after who knows how long (only noticed it the next day), the transaction failed with the message "Transaction decoding is not available for chainId 56" in the MM transaction data.

Relic180 avatar Feb 23 '22 17:02 Relic180

@Relic180 thanks for the note, I'm working towards prioritising this very soon. Apologies for the delay but thank you again for your comments.

AlexJupiter avatar Feb 23 '22 17:02 AlexJupiter

For any MetaMask engineers looking at this issue please also see this thread related to a similar issue reported by Brave https://consensys.slack.com/archives/C010AA832TX/p1645636789546909 and I have also been in touch with an institutional customer with a similar issue. This could be related to the passphrase feature in Trezor.

AlexJupiter avatar Feb 23 '22 20:02 AlexJupiter

Any updates? Looks like new version of MM was released (10.10.2) but issue is still there. Also, a new version of the Trezor Suite was released (22.2.3) although I forgot to check my version before the update. Firmware is the same, from last November.

I'm finding that basically any action I take from the hardware wallet doesn't work (the only action I can complete is connecting the wallet to an app, but not approving for anything or executing any transactions). I think it felt more intermittent before since I was still in the process of moving assets from the HotWallet into hardware, and all my transactions from the are HotWallet still working fine.

This wouldn't be such an issue for me, except that it seems that EVERYTHING I've moved over to hardware has effectively been locked and is completely inaccessible to me now, due to the fact that I also cannot transfer those assets back to my HotWallet.

EDIT: Again, I'd be more than happy to run errands and collect additional debugging details for you guys if it'll help uncover what's going on. Just let me know what you need.

Relic180 avatar Mar 04 '22 18:03 Relic180

Another update from both MM (10.11.1) and Trezor Suite (22.3.2), same behavior... all my assets that were sent to Hardware wallet address are stuck.

Is anybody even looking into this issue? Is progress being tracked in another bug maybe?

Relic180 avatar Mar 18 '22 14:03 Relic180

OS: Windows Hardware Wallet: Trezor Model One - Firmware version 1.10.5 Browser: Chrome MetaMask Version: 10.11.1 Everything updated.

Same issue here. Is anyone on the team working to fix it?

hekreates avatar Mar 21 '22 17:03 hekreates

Updated to MM 10.11.3, same issue.

Relic180 avatar Mar 26 '22 15:03 Relic180

I tried several times entering the passphrase directly on the Trezor device for several different types of transactions (sending through MM, approving a dapp, swapping via DEX), but I'm still having exactly same behavior: MM is frozen for a long while (+20 minutes) and eventually times out.

Currently at MM version 10.12.1

Relic180 avatar Apr 04 '22 05:04 Relic180

Realized after the last time I let the extension actually timeout (rather than killing/restarting it) that I had access to a log of the failed transaction. The stack trace for one of the errors was:

Error: Error: Unknown address\n at m._signTransaction (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:1:291507)\n at async G.signTransaction (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:1:229299)\n at async G.approveTransaction (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:1:227597)\n at async G.updateAndApproveTransaction (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:1:226988)\n at async a.<anonymous> (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:1:150051)

This was for a "type": "approve", but again I have the same behavior for any transaction I try. Here's another error during an attempted "type": "simpleSend" from within MM when trying to send funds back to my hot wallet to get access to them:

Error: Error: Unknown address\n at p._signTransaction (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:1:253423)\n at async U.signTransaction (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:1:221305)\n at async U.approveTransaction (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:1:220667)\n at async U.updateAndApproveTransaction (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:1:220058)\n at async a.<anonymous> (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-0.js:1:146838)

The 2nd error looks like the same, although probably a recompiled version of the mask so minified references and line numbers have changed slightly.

Relic180 avatar Apr 04 '22 14:04 Relic180

Same. After clicking to "Send Tx", Metamask is frozen. After ~4 minutes, Tx is failed. I see the error: unknown address

https://user-images.githubusercontent.com/54408225/163354014-35a674c2-12c4-476b-a7fd-39865e78c04d.mp4

Steps:

  1. Load a new build 10.13.0
  2. Unlock Trezor
  3. Create account in MM
  4. Import 3 Trezor addresses
  5. Make tx
  6. Accept on Trezor

image

I believe this has to do with the previous actions I did. Even though this was a fresh build, on the previous build I wanted to Import Trezor accounts and got the error Manifest not set. See this issue for more info. After that I logged out, remove the build and start a new one, with the result explained above. I suspect Trezor stayed on a certain state, leading to this behaviour, as Metamask was a new instance from scratch everytime.

seaona avatar Apr 14 '22 09:04 seaona