Daniel Azses
Daniel Azses
Probably the server doesn't count the minions kills at all.
Fountains do no damage to champions. Also, fountains can be destroyed (which is maybe intentional).
The current implementation is not very efficient. We should have min priority queue based on the buff duration and its status effects. I'll open an issue and we can implement...
https://github.com/LeagueSandbox/GameServer/blob/b4ac29d261c85408c57501bd2a9b8373f067659a/GameServerLib/Items/Item.cs#L18 This should be implemented in Stackable.
There are 2 main problem with strings in general: 1. All strings should be parsed using UTF8 to avoid localization problems. The chat for example need https://github.com/LeagueSandbox/LeaguePackets/blob/f51efafbbf15a508f05b3f6e487520a4f80a8de5/LeaguePackets/LoadScreen/104_Chat.cs#L17 this Localization flag...
Upon disconnect the function `HandleDisconnect` get called in `PacketHandlerManager`. The problem is that this function doesn't remove the peer and so packets continue to get sent to this peer. There...
Seems like in the APIEventManager there are inefficiencies due to lack of using inverse lists/hash tables. RemoveAllListeners calls each removal for every event, resulting in a linear search for every...
https://github.com/LeagueSandbox/GameServer/blob/f1c7bdcc160e9f01592dbb1713ad854f636805e9/PacketDefinitions420/PacketHandlerManager.cs#L195 Here PacketHeader only reads byte, that could be generally wrong, so currently the system only supports C2S below 0xFF id.
The packet parsing is missing the QuickChat channel, which is the 6th channel.
Turrets should implement 'true sight', which is a vision check that ignores obstacles/walls and so on. Currently, turrets can only target those that are in their vision.