Daniel Agar

Results 351 comments of Daniel Agar

Could you review if current `main` (after https://github.com/PX4/PX4-Autopilot/pull/20319 merged) now covers everything you need? You may also need to upgrade Gazebo with the small multirotor motor plugin update (https://github.com/gazebosim/gz-sim/pull/1689).

I think we need to handle both ESCs and Actuators. https://github.com/dronecan/DSDL/tree/master/uavcan/equipment/actuator

I think we need to handle both ESCs and Actuators. https://github.com/dronecan/DSDL/tree/master/uavcan/equipment/actuator

> This needs retesting since the mixer purge. The entire rc.interface can be purged now and replaced with just starting the output modules.

Any implications for the other tune control subscribers (UAVCAN and tap_esc)?

Can you do this on a clean branch (from current main) without all the extra changes? ![Screenshot from 2022-09-22 12-33-48](https://user-images.githubusercontent.com/84712/191802877-88996e9a-f946-4b59-a6e9-a8bfbeee5ed6.png)

We should rebase this PR on current `main`, I've merged the initial mavlink stream support in https://github.com/PX4/PX4-Autopilot/pull/20348.